Amit Shah wrote: > On (Fri) Mar 26 2010 [01:09:23], Jamie Lokier wrote: > > Amit Shah wrote: > > > The number of ports on the source as well as the destination machines > > > should match. If they don't, it means some ports that got hotplugged on > > > the source aren't instantiated on the destination. Or that ports that > > > were hot-unplugged on the source are created on the destination. > > > > Surely the set of guest-visible ids must match exactly and be checked > > (maybe mapped, if they were given in a different order), in which case > > counting the number of ports looks redundant. > > > > I.e. is this check hiding the omission of the proper one? > > Yes, That's added in a later patch (5). That patch changes the guest > abi, so it's separate. > > Also, patch 3 checks if all the ports on the src are present on the > dest.
Great, thanks :-) -- Jamie