On 02/27/2015 07:54 PM, zhanghailiang wrote: > On 2015/2/28 0:48, Eric Blake wrote: >> On 02/26/2015 11:19 PM, zhanghailiang wrote: >>> The original 'status' is an open-coded 'str' type, convert it to use an >>> enum type.
>>> +# @MigState: >> >> Do we have to abbreviate? I guess leaving it like this makes the rest >> of the existing code base have less churn (since it matches the spelling >> of the enum that was previous interanl only), but it might look nicer as > > Yes, this is the reason ..., agreed, i don't like the abbreviate, > But there is already a 'MigrationState' type defined: > > > So, what about MigrationStatus ? ;) That would be fine with me. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
