Michael Tokarev <m...@tls.msk.ru> writes: > Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c. > > All filesystem methods use common v9fs_request() function, > which returns -errno. So far so good. > > Now, *all* places which call this function, does this: > > retval = v9fs_request(...); > if (retval < 0) { > errno = -retval; > } > return retval; > > and *some* does this: > > retval = v9fs_request(...); > if (retval < 0) { > errno = -retval; > retval = -1; > } > return retval;
We should be able to drop that retval = -1; -aneesh