Hi John, Vladimir We can using active block commit to implement incremental backup without guest disruption, e.g., origin <= A <= B <= C <= current BDS, a new external snapshot will be produced before every time backup, we can migrate A, B, C, ... to destination, then commit_active_start() the unneeded snapshot in source or destination end.
So, comparing with above mechanism, what's the advantages of the incremental backup implemented by John and Vladimir? Thanks, Zhang Haoyu On 2015-03-09 15:38:40, Paolo Bonzini wrote: > >On 09/03/2015 08:03, Zhang Haoyu wrote: >> >> On 2015-03-03 18:00:09, Paolo Bonzini wrote: >>> >>> On 03/03/2015 07:52, Zhang Haoyu wrote: >>>> Hi, >>>> If introducing bitmap to bdrv_commit to track dirty sector, >>>> could we implement guest non-disruption while performing commit? >>> >>> That is already implemented. It uses the same code that implements >>> storage migration (block/mirror.c). >>> >> Hi Paolo, >> do you mean commit_active_start()? > >Yes. > >Paolo