On 12 February 2015 at 17:08, Andrew Jones <drjo...@redhat.com> wrote: > On Thu, Feb 12, 2015 at 04:05:07PM +0100, Andrew Jones wrote: >> Now that we have get_S1prot, we can apply it to get_phys_addr_v6 >> for a minor code cleanup.
I think this is a bad idea -- better to keep the long and short descriptor code paths separate. It's too easy to get confused otherwise. > Actually, I should point out that this isn't just a cleanup, but > also a fix. See below. > The original code didn't take into account that it may be calling check_ap > with a simple AP, AP[2:1]. No, because check_ap() always takes AP[2:0]... -- PMM
