On 03/13/2015 11:48 AM, Markus Armbruster wrote:
> Markus Armbruster <arm...@redhat.com> writes:
> 
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
>> added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

"always" is a strong word; there are cases where alternate error classes
are useful.  But I agree that this does not seem to be one of those
cases.  Therefore:

> 
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> 
>>  ui/vnc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <ebl...@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to