On 23 March 2015 at 15:18, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 23/03/2015 16:11, Peter Maydell wrote: >> On 23 March 2015 at 14:39, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> On 23/03/2015 13:24, Peter Maydell wrote: >>>> * ld/st*_phys to be renamed to as_ld*, eg >>>> ldub_phys -> as_ldub >>>> ldl_be_phys -> as_ldl_be >>>> stq_phys -> as_stq >>>> stl_le_phys -> as_ldl_le >>> >>> I think shorthand functions with no extra arguments still have a place. >> >> The trouble is that since C doesn't do polymorphism you >> then end up with awkward names for one or the other... > > True. But since it's not a new API we can keep the old name for the > simple one.
...except that means that the function you should in general not be using as default is the one with the short name, which is the wrong way round. We should be guiding people writing new code to think about the required behaviour on memory transaction failure (and attributes) as they write the code, not making it easy for them to ignore the issue... -- PMM
