Eric Blake <ebl...@redhat.com> writes: > For a few QMP commands, we are forced to pass an arbitrary type > without tracking it properly in QAPI. Among the existing clients, > this unnamed type was spelled 'dict', 'visitor', and '**'; this > patch standardizes on '**'. > > Meanwhile, for both 'gen' and 'success-response' keys, we have been > ignoring the value, although the schema consistently used "'no'". > But now that we can support a literal "false" in the schema, we > might as well use that rather than ignoring the value or > special-casing a random string. > > There is no difference to the generated code. As these features > were previously undocumented before this series, add some tests > and documentation on what we'd like to guarantee, although it will > take later patches to clean up test results and actually enforce > the use of a bool parameter.
You don't actually add documentation in this patch. Aside: 'gen': false is required when '**' is used anywhere in the command. If it was permitted only then, it would be redundant. I think we happily accept 'gen': false without '**' so far, although we don't use it. That's okay. > Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com>
