On 4/4/10, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 04/03/2010 11:07 AM, Blue Swirl wrote: > > > On 4/3/10, Paolo Bonzini<pbonz...@redhat.com> wrote: > > > > > On 04/02/2010 09:04 PM, Blue Swirl wrote: > > > > > > > > > > -int kvm_init(int smp_cpus); > > > > > > > > > > > > > > I had missed this; I don't see a particular reason to move this out of > > > kvm.h. Anyway I don't feel strongly about this. > > > > > > > The reason is to avoid including kvm.h by vl.c. > > > > But that's not a problem, kvm.h can be included by compiled-once files; > that was the reason to introduce the stubs in the first place. kvm_* should > be declared in kvm.h.
That can't be safe because CONFIG_KVM will not be defined for files compiled once. So even with the stubs, those files would use inlined stubs where they shouldn't.
