On Mon, Apr 05, 2010 at 08:01:16PM +0200, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Thu, Apr 01, 2010 at 11:56:25PM +0200, Stefan Weil wrote: > >> u_int64_t raises compiler error messages: > >> > >> CC libhw32/virtio.o > >> /qemu/ar7/hw/virtio.c: In function ‘virtio_queue_get_avail_size’: > >> /qemu/ar7/hw/virtio.c:776: error: ‘u_int64_t’ undeclared (first use > >> in this function) > >> /qemu/ar7/hw/virtio.c:776: error: (Each undeclared identifier is > >> reported only once > >> /qemu/ar7/hw/virtio.c:776: error: for each function it appears in.) > >> > >> Replacing u_int64_t by uint64_t helps. > >> > >> Cc: Michael S. Tsirkin <m...@redhat.com> > >> Cc: Anthony Liguori <aligu...@us.ibm.com> > >> Signed-off-by: Stefan Weil <w...@mail.berlios.de> > > > > Acked-by: Michael S. Tsirkin <m...@redhat.com> > > > > Speaking of which, we have: > > /scm/qemu/slirp/slirp.h:typedef uint64_t u_int64_t; > > > > which we probably don't need either? > > Right. I'd even prefer replacing all those u_int#_t types > by the standard types uint#_t. > > Is that ok, or would you prefer not to touch the slirp code > (which makes heavy use of those types)? > > Regards, > Stefan
I don't think we should modify all of slirp code. However u_int64_t specifically seems unused. -- MST
