On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven <p...@kamp.de> wrote:

Please CC qemu-devel@nongnu.org in the future.  All patches must be on
the qemu-devel mailing list so they can be merged (for transparency).
I have added qemu-devel to CC.

> +    /* newer versions of libiscsi may return zero events. In this
> +     * case start a timer to ensure we are able to return to service
> +     * once this situation changes. */
> +    if (!ev) {
> +        timer_mod(iscsilun->event_timer,
> +                  qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + EVENT_INTERVAL);
>      }

This suggests that libiscsi is waiting on its own internal timer.  It
would be cleaner for libiscsi to provide a timeout value so the
application doesn't need to poll the library.  Is there still scope to
modify libiscsi to do this?

Reply via email to