On 04/12/2015 07:56 PM, Zhu Guihua wrote: > > On 04/10/2015 11:37 PM, Eric Blake wrote: >> On 04/02/2015 03:50 AM, Zhu Guihua wrote: >>> When memory hot unplug fails, this patch adds support to send >>> QMP event to notify mgmt about this failure. >>> >>> Signed-off-by: Zhu Guihua <zhugh.f...@cn.fujitsu.com> >>> --- >>> docs/qmp/qmp-events.txt | 17 +++++++++++++++++ >>> hw/acpi/memory_hotplug.c | 10 +++++++++- >>> monitor.c | 1 + >>> qapi/event.json | 14 ++++++++++++++ >>> trace-events | 1 + >>> 5 files changed, 42 insertions(+), 1 deletion(-)
>>> +## >>> +# @MEM_UNPLUG_ERROR >>> +# >>> +# Emitted when memory hot unplug error occurs. >>> +# >>> +# @device: device name >>> +# >>> +# @msg: Informative message >> Any reason you abbreviated instead of spelling it out as 'message'? > > This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED > in docs/qmp/qmp-events.txt. Just because existing code abbreviated does not mean that new code needs to copy the bad example. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
