Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

[Paolo Bonzini]

On 20/04/2015 11:19, Gerd Hoffmann wrote:
> +    memory_region_del_subregion(mch->system_memory, &mch->tseg_blackhole);
> +    memory_region_set_enabled(&mch->tseg_blackhole, tseg_size);

Please use "tseg_size > 0" here.

Paolo

> +    memory_region_set_size(&mch->tseg_blackhole, tseg_size);
> +    memory_region_add_subregion_overlap(mch->system_memory,
> +                                        mch->below_4g_mem_size - tseg_size,
> +                                        &mch->tseg_blackhole, 1);