On Tue, 21 Apr 2015 09:43:36 +0800 Shannon Zhao <shannon.z...@linaro.org> wrote:
> On 2015/4/20 19:32, Cornelia Huck wrote: > > On Mon, 20 Apr 2015 16:20:00 +0800 > > shannon.z...@linaro.org wrote: > > > >> From: Shannon Zhao <shannon.z...@linaro.org> > >> > >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > >> The transports just sync the host features from backend. > >> > >> Signed-off-by: Shannon Zhao <zhaoshengl...@huawei.com> > >> Signed-off-by: Shannon Zhao <shannon.z...@linaro.org> > >> --- > >> hw/net/virtio-net.c | 4 ++++ > >> hw/s390x/s390-virtio-bus.c | 1 - > >> hw/s390x/virtio-ccw.c | 1 - > >> hw/virtio/virtio-pci.c | 1 - > >> include/hw/virtio/virtio-net.h | 1 + > >> 5 files changed, 5 insertions(+), 3 deletions(-) > > > > I need the following change to make this work for virtio-ccw: > > > > > Maybe we can use following patch. This moves virtio_net_set_config_size to > virtio_net_device_realize function. As the features are moved to virtio-net, > so we should set the config_size in virtio-net too. And this can be useful to > virtio-mmio which now doesn't call virtio_net_set_config_size in > virtio-mmio's realize function. I think this makes sense. > > Cornelia, could you check if this works on s390? Thanks. Networking works again via virtio-ccw with this patch on top. I'll still try to figure out a better sequence for realizing/plugging virtio-ccw devices, but I think that is orthogonal to this patch.