On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: > A predefined scope in the ACPI specs is precede with a backslash. > > Signed-off-by: Gal Hammer <gham...@redhat.com>
s/precede/preceded/ This is correct, but do we need this in 2.3? I'm split on this. Thoughts? If yes, commit log needs better explanation on what the effect on guests is. > --- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 8d1a761..05c1d34 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -856,7 +856,7 @@ build_ssdt(GArray *table_data, GArray *linker, > aml_append(ssdt, scope); > } > > - sb_scope = aml_scope("_SB"); > + sb_scope = aml_scope("\\_SB"); > { > /* create PCI0.PRES device and its _CRS to reserve CPU hotplug MMIO > */ > dev = aml_device("PCI0." stringify(CPU_HOTPLUG_RESOURCE_DEVICE)); > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 48afb72..cb80f2a 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -120,7 +120,7 @@ void free_aml_allocator(void); > * Joins Aml elements together and helps to construct AML tables > * Examle of usage: > * Aml *table = aml_def_block("SSDT", ...); > - * Aml *sb = aml_scope("\_SB"); > + * Aml *sb = aml_scope("\\_SB"); > * Aml *dev = aml_device("PCI0"); > * > * aml_append(dev, aml_name_decl("HID", aml_eisaid("PNP0A03"))); > -- > 2.1.0