On 05/05/2015 12:19 PM, Paolo Bonzini wrote: > > > On 05/05/2015 17:48, John Snow wrote: >> I specifically left things that alter control flow using hex nibbles -- >> such as the FIS packets, PRD tables, and all other existing tests. I >> only use the b64 encoding for raw data patterns, which don't really need >> to be debugged. Either they match or they don't: any particular values >> are uninteresting. > > To some extent: they may still be interesting for stuff like IDENTIFY. >
You got me there. >> Any future test can be switched to/from hex/b64 by just altering >> "mem{read,write}()" to "buf{read,write}()" as desired. I specifically >> opted not to alter *all* qtest IO for this very reason. >> >> Does that help? :) > > Yes. We could also switch unconditionally to b64, but keep hex in the > qtest-log. > Hmm, there's a thought. Though b64 for a handful of bytes seems definitely likely to be slower. I am comfortable having two implementations at the moment. (Mostly because I don't feel like testing what the threshold for which strings should be sent with what method is. Too much effort for qtest.) hex-always in the log is a good idea, though. I may do that. >> If you're not opposed to the rest of this series, I will send a v2 >> including the hex batching optimization. > > This series is okay. I just wanted some clarifications and ideas for > future work. > > Paolo > Just trying to make you happy ;) --js