On Tue, 5 May 2015 10:14:32 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote:
> On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > The HMP command info cpus now displays the CPU model name and the > > backing accelerator if part of the CPUState. > > > > (qemu) info cpus > > * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 > > > > Signed-off-by: Michael Mueller <m...@linux.vnet.ibm.com> > > Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > > Do we really need this? I mean: I expect the amount of CPU data we > provide to QMP clients to grow a lot in the near future, but that > doesn't mean HMP users need all that data to be printed by "info cpus". Where do you see the limit of what is worth to be shown an what not. I personally use "info cpus" less then sporadic but already got a comment internally on that information being worthwhile to be shown. > > > > --- > > hmp.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/hmp.c b/hmp.c > > index f142d36..676d821 100644 > > --- a/hmp.c > > +++ b/hmp.c > > @@ -290,6 +290,13 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) > > monitor_printf(mon, " (halted)"); > > } > > > > + if (cpu->value->has_model) { > > + monitor_printf(mon, " model=%s", cpu->value->model); > > + } > > + if (cpu->value->has_accel) { > > + monitor_printf(mon, " accel=%s", > > AccelId_lookup[cpu->value->accel]); > > + } > > + > > monitor_printf(mon, " thread_id=%" PRId64 "\n", > > cpu->value->thread_id); > > } > > > > -- > > 1.8.3.1 > > >