On Fri, 17 Apr 2015 09:52:37 +0200 Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> From: Xu Wang <gesa...@linux.vnet.ibm.com> > > A new sysbus device for diag288 watchdog, it monitors the kvm guest > status, and take corresponding actions when it detects that the guest > is not responding. > > Signed-off-by: Xu Wang <gesa...@linux.vnet.ibm.com> > Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> > Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> > --- > default-configs/s390x-softmmu.mak | 1 + > hw/watchdog/Makefile.objs | 1 + > hw/watchdog/wdt_diag288.c | 110 > ++++++++++++++++++++++++++++++++++++++ > include/hw/watchdog/wdt_diag288.h | 36 +++++++++++++ > qemu-options.hx | 6 ++- > 5 files changed, 152 insertions(+), 2 deletions(-) > create mode 100644 hw/watchdog/wdt_diag288.c > create mode 100644 include/hw/watchdog/wdt_diag288.h OK, after some deliberation, I think it is best to model the diag288 watchdog as a bus-less device: The other watchdogs are modelled as devices as well, and it is probably a good idea to stay with this model as other parties may have made assumptions based on this. Xu, can you please switch the diag288 device to TYPE_DEVICE and address Markus' comments regarding the help text as well?
