On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Before we can allow updating options at runtime with bdrv_reopen(), we > need to split the function into prepare/commit/abort parts. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/qcow2.c | 101 > ++++++++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 67 insertions(+), 34 deletions(-) >
In isolation, it looks like a valid conversion, so: Reviewed-by: Eric Blake <ebl...@redhat.com> However, given that we are having a conversation on another thread about semantics for prepare vs. commit being the action that actually changes the in-memory representation, is this the correct split for however we end up resolving that bug? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
