On Thu, Apr 30, 2015 at 6:32 PM, Paolo Bonzini <pbonz...@redhat.com>
wrote:
On 30/04/2015 10:59, Jason Wang wrote:
+ /* If !can_send, we will want to disable the read poll,
but
we still
+ * need the send completion callback to enable it again,
which is a
+ * sign of peer becoming ready. So call the send function
+ * regardlessly of can_send.
+ */
It was probably not safe to depend on sent_cb to re-enable the
polling.
Since the packet could be purged in some conditions (e.g
net_vm_change_state_handler()). So tap_send_completed won't be
called in
this case.
Doesn't qemu_net_queue_purge also call the sent_cb?
Paolo
I was wrong. It calls.
