On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: > On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: > > The qemu-io tool does not check if the image is encrypted so > > historically would silently corrupt the sectors by writing > > plain text data into them instead of cipher text. The earlier > > commit turns this mistake into a fatal abort, so check for > > encryption and prompt for key when required. > > Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3 > patches? Should this be rearranged so that 1/5 comes after this to > avoid triggering the abort?
I'm ambivalent on that - previously qemu-io was data corrupting for this scenario, so crashing isn't really that much worse :-) It is easy enough to reorder these though if that's desired. The latter patches have no build time dep on the 1st patch, so its trivial for Kevin to re-order when applying if he thinks it is worth it. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
