Eric Blake <ebl...@redhat.com> writes: > On 05/12/2015 06:02 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> net/tap.c | 14 +------------- >> 1 file changed, 1 insertion(+), 13 deletions(-) >> > >> @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, const >> char *name, >> } >> >> fcntl(fd, F_SETFL, O_NONBLOCK); > > Well, fcntl() could fail. And don't we have the helper function > util/oslib-posix.c:qemu_set_nonblock() for doing this correctly? (Then > again, that helper also ignores failures). > > But the raw use of fcntl here is pre-existing and you didn't touch it, > so it doesn't affect my review of this patch.
I guess using the helper makes some sense here, but it's outside this series' scope. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!
