Alexey Kardashevskiy <a...@ozlabs.ru> writes: > On 05/19/2015 02:51 PM, Nikunj A Dadhania wrote: >> Alexey Kardashevskiy <a...@ozlabs.ru> writes: >> >>> On 05/07/2015 05:21 PM, Nikunj A Dadhania wrote: >>>> Each hardware instance has a platform unique location code. The OF >>>> device tree that describes a part of a hardware entity must include >>>> the “ibm,loc-code” property with a value that represents the location >>>> code for that hardware entity. >>>> >>>> Populate ibm,loc-code. >>>> >>>> 1) PCI passthru devices need to identify with its own ibm,loc-code >>>> available on the host. In failure cases use: >>>> vfio_<name>:<phb-index>:<slot>.<fn> >>>> >>>> 2) Emulated devices encode as following: >>>> qemu_<name>:<phb-index>:<slot>.<fn> >>>> >>>> Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com> >>>> --- >>>> hw/ppc/spapr_pci.c | 98 >>>> +++++++++++++++++++++++++++++++++++++++++++++++------- >>>> 1 file changed, 86 insertions(+), 12 deletions(-) >>>> >>>> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c >>>> index 12f1b9c..d901007 100644 >>>> --- a/hw/ppc/spapr_pci.c >>>> +++ b/hw/ppc/spapr_pci.c >>>> @@ -769,6 +769,81 @@ static uint32_t >>>> spapr_phb_get_pci_drc_index(sPAPRPHBState *phb, >>>> return drck->get_index(drc); >>>> } >>>> >>>> +static bool spapr_phb_vfio_get_devspec_value(PCIDevice *pdev, char >>>> **value) >>> >>> Does it have to be a separate function? >> >> For better readability, i would prefer it this way. > > This is why I asked - I was having problems understanding the difference > between these two having 6 words names ;) Do not insist though.
Let me see if I can simplify this. Regards Nikunj
