On Tue, May 19, 2015 at 11:49:36AM +0530, Bharata B Rao wrote: > On Mon, May 18, 2015 at 03:36:54PM -0300, Eduardo Habkost wrote: > > On Tue, May 12, 2015 at 11:06:25AM +0530, Bharata B Rao wrote: [...] > > > void cpu_exec_init(CPUArchState *env, Error **errp) [...] > > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > > > index 39f0f19..7db310e 100644 > > > --- a/include/qom/cpu.h > > > +++ b/include/qom/cpu.h > > > @@ -672,6 +672,7 @@ void cpu_watchpoint_remove_all(CPUState *cpu, int > > > mask); > > > > > > void QEMU_NORETURN cpu_abort(CPUState *cpu, const char *fmt, ...) > > > GCC_FMT_ATTR(2, 3); > > > +void cpu_exec_exit(CPUState *cpu); > > > > Why don't we keep both cpu_exec_init() and cpu_exec_exit() in the same > > header file? > > Currently cpu_exec_init() is in exec-all.h. > > 1. If I put cpu_exec_exit() also there, qom/cpu.c doesn't like it since > many definitions (like ram_addr_t etc) aren't known in qom/cpu.c. > > 2. I can't move cpu_exec_init() declaration to qom/cpu.h since it results > in the use of poisoned definition of CPUArchState from qom/cpu.c
OK, so we can change cpu_exec_init() to use CPUState in a follow-up patch later. Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo
