On 2015/5/28 20:34, Michael Tokarev wrote: > 28.05.2015 15:08, Shannon Zhao wrote: >> From: Shannon Zhao <shannon.z...@linaro.org> >> >> Before I sent some patches to fix memory leak spotted by valgrind and >> those are relevant to qemu_allocate_irqs. Then I find all the places >> calling this function through code searching and test by valgrind to >> check whether they have memory leak. These patches fix these memory leaks. >> >> Sorry that maybe the names of the patches are vertiginous while I could >> not find out better names and I try to sort them out. > > Maybe a better subject will be "fix memory leak after qemu_allocate_irqs" > or something like that? And for some, "use qemu_allocate_irq not _irqs > for single irq" -- this kind is sorta fun, I wonder why the codebase has > so many cases of this API misuse. > > And one more question: do you really care that whole valgrind report is > included into every commit message? :) not really, while these reports show people the problems. You could deal them in your way.
Thanks, -- Shannon
