On Tue, May 19, 2015 at 08:13:18PM -0700, sfel...@gmail.com wrote: > From: Scott Feldman <sfel...@gmail.com> > > v2: > > Address review comments from Stefan Hajnoczi: > > - Add missing qapi/rocker.json file. > - Use PRIx64 for print uint64 value > - when CONFIG_ROCKER is not defined, build qmp-norocker.o stub using > hw/net/Makefile.objs rather than in the top-level Makefile.target
qmp-norocker.c is missing from this patch series:
make[1]: *** No rule to make target 'hw/net/rocker/qmp-norocker.o', needed by
'qemu-system-arm'. Stop.
> +void hmp_rocker_ports(Monitor *mon, const QDict *qdict)
> +{
> + RockerPortList *list, *port;
> + const char *name = qdict_get_str(qdict, "name");
> + Error *errp = NULL;
> +
> + list = qmp_query_rocker_ports(name, &errp);
> + if (errp != NULL) {
> + hmp_handle_error(mon, &errp);
> + return;
> + }
> +
> + monitor_printf(mon, " ena/ speed/ auto\n");
> + monitor_printf(mon, " port link duplex neg?\n");
> +
> + for (port = list; port; port = port->next)
Please add curly brackets. QEMU coding style always uses them even for
single statement if/for bodies.
pgpCJe76be49x.pgp
Description: PGP signature
