P J P <p...@fedoraproject.org> writes: > Hello Markus, > >> On Monday, 1 June 2015 1:28 PM, Markus Armbruster <arm...@redhat.com> wrote: >> Michael (cc'ed) already posted "[PATCH] slirp: use less predictable >> directory name in /tmp for smb config (CVE-2015-4037)"[*]. His patch >> clobbers s->smb_dir[] when mkdtemp() fails (missed that in my review), >> yours doesn't. >> >> Suggest you guys figure out together which solution you want. > > > Thank you so much for the review. IMO using separate smb_dir[] is > prudent than s->smb_dir.
Let's go with Michael's v2, because it also fixes the "cleanup after mkdir() / mkdtemp() failed" scenario. [...]
