Re: [Qemu-devel] [PATCH v3 2/8] target-sh4: Split out T from SR

[Richard Henderson]

On 05/24/2015 04:37 PM, Aurelien Jarno wrote:

@@ -174,6 +176,16 @@ void superh_cpu_dump_state(CPUState *cs, FILE *f,
                    env->delayed_pc);
      }
  }
+static void gen_read_sr(TCGv dst)
+{
+    tcg_gen_or_i32(dst, cpu_sr, cpu_sr_t);
+}

Watch the spacing.

          /* MOVCO.L
@@ -1558,8 +1523,7 @@ static void _decode_opc(DisasContext * ctx)
          */
          if (ctx->features & SH_FEATURE_SH4A) {
              TCGLabel *label = gen_new_label();
-            tcg_gen_andi_i32(cpu_sr, cpu_sr, ~(1u << SR_T));
-           tcg_gen_or_i32(cpu_sr, cpu_sr, cpu_ldst);
+            tcg_gen_mov_i32(cpu_sr, cpu_ldst);

Move to cpu_sr_t.


r~