On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote:
> >
> >-        ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> >-                          pft_size_prop, sizeof(pft_size_prop));
> 
> You broke formatting here, above 8 lines should not be in the patch.

You mean above 80 chars ? It is not above 80 chars.

> >+    _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size",
> >+                            env->dcache_line_size)));
> 
> Wrong indent.

checkpatch.pl doesn't complain, but should we start the second line
below ( of the first line ?

Regards,
Bharata.


Reply via email to