On Fri, Jun 05, 2015 at 05:17:29PM +0300, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html > > Signed-off-by: Pavel Fedin <p.fe...@samsung.com> > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/monitor.c b/monitor.c > index c7baa91..ef21bba 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, > Error **errp) > "arguments", "object"); > return NULL; > } > + } else if (!strcmp(arg_name, "id")) { > + /* Ignored, necessary for backwards compatibility */ > } else { > error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); > return NULL;
This should probably be accompanied by an update to docs/qmp/qmp-spec.txt to say this is ignored and remove the bit about it being copied into the replies Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
