Hello!

> > +int arm_cpus_per_cluster = 8;
> 
> This doesn't need to be global, it doesn't need to be exposed in
> a header file, and it definitely doesn't need to be non-constant.
> I suggest
> #define ARM_CPUS_PER_CLUSTER 8

 It was a #define in v3, but i decided to change this in order to allow machine 
models to request different topology as Igor suggested. Of course you can 
revert to #define if you strictly want to.

> These are minor nits so I plan to just fix them as I apply
> this to target-arm.next, unless you object.

 No, i don't object and of course i'm waiting for the PULL.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia



Reply via email to