On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> qerror_report() is a transitional interface to help with converting
> existing monitor commands to QMP. It should not be used elsewhere.
> Replace by error_report().
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> tpm.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tpm.c b/tpm.c
> index 99a9895..224e65e 100644
> --- a/tpm.c
> +++ b/tpm.c
> @@ -140,23 +140,21 @@ static int configure_tpm(QemuOpts *opts)
>
> id = qemu_opts_id(opts);
> if (id == NULL) {
> - qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER,
> "id");
> + error_report(QERR_MISSING_PARAMETER, "id");Ah, this fixes a hunk difference I pointed out in 5/11. If you need to rebase, I'd consider rearranging to put this patch first, so that the mechanical 5/11 is even more mechanical (limited to just error_setg conversion). But that's not enough reason in itself for a respin, so: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
