Peter Crosthwaite <crosthwaitepe...@gmail.com> writes: > Neither the monitor or disassembly core has a good reason to navigate from an > env pointer to a cpu pointer. Disas should not need env awarness at all, that > is removed in P2. > > The monitor is trickier, the env is still needed by some #ifdef switched > target > specific code but all common code only needs to trade in CPU pointers. As the > monitor always has access to a CPU pointer naturally, remove ENV_GET_CPU > usages > (P1). > > This is related to my multi-arch work, where the goal is to minimise use of > architecture defined global definitions, ENV_GET_CPU being a major headache in > that whole effort. The longer term goal is to limit ENV_GET_CPU use to > genuinely > architecture specific code. > > But I think these two patches stand in their own right, so sending ahead of > the > motherload series. This brings both modules closer to common-oby-y'ification. > > First RFC for multi arch is avaiable here: > > https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01771.html > > The two patches are done together to avoid a conflict with monitor_disas which > is touched by both patches. If one patch gets acked, the other nacked then > either can be merged independently with trivial edits.
Applied to my (badly named) qapi-next branch, thanks!
