On Wed, Jun 17, 2015 at 09:15:56PM +0200, Paolo Bonzini wrote:
>
>
> On 17/06/2015 20:43, Michael S. Tsirkin wrote:
> > It seems pretty obvious:
> >
> > + vmport_rpc = isa_try_create(isa_bus, "vmport_rpc");
> > + if (vmport_rpc) {
> > + qdev_init_nofail(DEVICE(vmport_rpc));
> > + }
> >
> >
> > Don't do this. Let user specify the device using -device vmport_rpc.
> > Then all issues just go away. I don't see any reason not to do it like
> > this - we should have done the same for other vmport things.
>
> Does it make sense to have an ISA device that has no ports or MMIO
> regions? It's a bit of hack modeling-wise, but sure it works.
>
> Paolo
I didn't write this code :)
--
MST
