* Juan Quintela (quint...@redhat.com) wrote:
> cmpxchg returns the old value
>
> Signed-off-by: Juan Quintela <quint...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Nice spot.
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index f1ecf76..1791185 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -505,7 +505,7 @@ void qmp_migrate_set_parameters(bool has_compress_level,
>
> static void migrate_set_state(MigrationState *s, int old_state, int
> new_state)
> {
> - if (atomic_cmpxchg(&s->state, old_state, new_state) == new_state) {
> + if (atomic_cmpxchg(&s->state, old_state, new_state) == old_state) {
> trace_migrate_set_state(new_state);
> }
> }
> --
> 2.4.3
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
