On 18/06/2015 10:58, zhanghailiang wrote: > +void qemu_system_shutdown_request(void) > +{ > + trace_qemu_system_shutdown_request(); > + /* > + * if in colo mode, we need do some significant work before respond to the > + * shutdown request. > + */ > + if (loadvm_in_colo_state()) { > + return ; /* primary's responsibility */ > + } > + if (migrate_in_colo_state()) { > + colo_shutdown_requested = 1; > + return; > + }
The patch looks sane---the only comment I have is that loadvm_in_colo_state() and migrate_in_colo_state() do not sound like great names. Paolo > + qemu_system_shutdown_request_core(); > +} > +