On 19 June 2015 at 11:07, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: >> In case NDEBUG is defined, assert() expands to nothing and >> vhost_net_set_vnet_endian() doesn't get called... >> >> Suggested-by: Thomas Huth <th...@redhat.com> >> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > > Not sure what the point is. > We don't support building with NDEBUG.
Putting functional behaviour inside an assert() is still a really bad idea. If you're reading the code you probably skim over the assert() as not functionally relevant... -- PMM
