Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support

[Paolo Bonzini]

On 12/06/2015 14:57, Stefan Hajnoczi wrote:
> +    RockerSwitch *rocker = g_malloc0(sizeof(*rocker));
> +    Rocker *r;
> +
> +    r = rocker_find(name);
> +    if (!r) {
> +        error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> +                  "rocker %s not found", name);
> +        return NULL;

Memory leak, please initialize rocker after the "if".

Paolo

> +    }
> +
> +    rocker->name = g_strdup(r->name);