Eric Blake <ebl...@redhat.com> writes: > On 06/22/2015 01:26 PM, Markus Armbruster wrote: >> Saves a tiny amount of code at every call site. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> include/qapi/error.h | 4 ++-- >> util/error.c | 9 +++++++++ >> 2 files changed, 11 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > (Interesting that you turn it back into a macro later in the series...)
Yes, in PATCH 7, but even then error_setg_internal() remains a function, not a macro wrapper around error_set_internal(), thus we still save code to pass a 0 argument at every call site. Of course, PATCH 7 increases code size quite a bit more than this patch decreases it: this patch deletes "pass 0 argument", PATCH 7 adds "pass __FILE__ and __LINE__ arguments". Plus the __FILE_ literals, but those should be in cold memory. If the increase bothers us, we could add suitable #ifdeffery to optionally suppress it. Seems not worth it to me.
