On 23/06/2015 13:18, Daniel P. Berrange wrote: > > For 2.5, however, I wonder if SuspendThread/ResumeThread is needed at > > all now that cpu_exit doesn't have to undo block chaining anymore. Even > > on POSIX platforms the signal might not be necessary anymore. > > If you don't have that signal / SuspendThread/ResumtThread requirement,
That was independent of QEMU reinventing the wheel for mutexes/condvars. > might that enable QEMU to just depend on the winpthreads library that > is provided by Mingw project, and not bother reinventing the wheel for > thread library portabilty ? We can and should just reuse glib these days as much as we can (probably not entirely because glib doesn't have detached threads). At least a few years ago, winpthreads was much slower than native Win32, which is why everyone reinvents the wheel. I was planning to do it in 2.5. Paolo
