On Mon, 29 Jun 2015 13:50:24 +0530 Bharata B Rao <bhar...@linux.vnet.ibm.com> wrote:
> HotplugHandlerClass::plug() shouldn't fail and hence use error_abort > to abort if it fails. > > Signed-off-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> > --- > hw/i386/pc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 8df1f3e..a66416d 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, > } > > hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); > - hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); > + hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort); > out: > error_propagate(errp, local_err); > }
