Hey! since RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html] - Added Acks - Followed 'xen: Print and use errno where applicable.' suggestion by Stefano and added a wrapper.
As I am in the process of syncing the 'dev.config' and Xen's internal cache of the PCI config space I noticed that some oddities in the code and figured that having them in would be easier for me (so I don't have to handle 20 odd patches). Stefano, patches 1-3 are unchanged since the RFC posting (well, they have the Ack tag added). Patch: [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap uses the new wrapper you suggested. The last two patches are new and I missed them the first time I posted: [PATCH v1 5/6] xen/pt/msi: Add the register value when printing [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against In short, please review #4,#5, and #6. hw/xen/xen_pt.c | 6 +++--- hw/xen/xen_pt.h | 1 - hw/xen/xen_pt_config_init.c | 8 ++++---- hw/xen/xen_pt_msi.c | 2 +- include/hw/xen/xen_common.h | 22 ++++++++++++++++++++++ xen-hvm.c | 4 ++-- 6 files changed, 32 insertions(+), 11 deletions(-) Konrad Rzeszutek Wilk (6): xen/pt: Update comments with proper function name. xen/pt: Make xen_pt_msi_set_enable static xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure xen: use errno instead of rc for xc_domain_add_to_physmap xen/pt/msi: Add the register value when printing logging and error messages xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.