On 7 July 2015 at 14:06, Olga Krishtal <okrish...@parallels.com> wrote: > On 07/07/15 13:32, Peter Maydell wrote: >> >> On 7 July 2015 at 05:40, Michael Roth <mdr...@linux.vnet.ibm.com> wrote: >>> >>> Hi Peter, >>> >>> Sorry for the last minute pull. This is a round-up of all tested/reviewed >>> qemu-ga patches posted prior to soft-freeze, along with 1 bug fix that >>> came in last week. >>> >>> This adds win32 implementations of: >>> guest-get-fsinfo >>> guest-network-get-interfaces >>> >>> and modifies guest-fstrim to return per-mount results and continue on to >>> other >>> mounts even when a failure is encountered. >>> >>> There's also bug fixes for guest-fstrim and guest-set-time. >>> >>> The following changes since commit >>> 7edd8e4660beb301d527257f8e04ebec0f841cb0: >>> >>> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >>> staging (2015-07-06 14:03:44 +0100) >>> >>> are available in the git repository at: >>> >>> >>> git://github.com/mdroth/qemu.git tags/qga-pull-2015-07-06-tag >>> >>> for you to fetch changes up to d1ad92aab4a9419538b7b1b7423a8a770c7a2859: >>> >>> qga: added GuestPCIAddress information (2015-07-06 23:06:12 -0500) >>> >>> ---------------------------------------------------------------- >>> tag for qga-pull-2015-07-06 >> >> Hi. I'm afraid this doesn't build for me for Windows: >> >> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:21:22: >> error: ws2ipdef.h: No such file or directory >> CC qga/vss-win32.o >> CC qga/qapi-generated/qga-qapi-types.o >> /home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:25:22: >> error: ntddscsi.h: No such file or directory > > I am using the following mingw cross > [gray_pig@gray qemu]$ rpm -qf > /usr/x86_64-w64-mingw32/sys-root/mingw/include/ntddscsi.h > mingw64-headers-4.0.2-1.el7.noarch > > Do we have minimal version which should be supported for the > case? If so, should we use config option for this or bump > minimal version? > > IMHO this is the root of all problems below.
Yes, my windows build environment is a fairly old one (ubuntu host, mingw32-runtime 3.15.2-0ubuntu1). It looks like in older versions of mingw this header is in ddk/ntddscsi.h, see for instance: http://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/4c1e3bce.6090...@yahoo.de/ It's OK if we make new features dependent on having a newer mingw, but you need to have a configure check to make sure the things you depend on exist. thanks -- PMM