[Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes

[Gerd Hoffmann]

  Hi,

-static int unix_write(int fd, const uint8_t *buf, int len1)
+static int unix_write(int fd, const uint8_t *buf, int len1, bool nonblock)
  {
      int ret, len;

@@ -522,6 +537,9 @@ static int unix_write(int fd, const uint8_t *buf, int len1)
      while (len>  0) {
          ret = write(fd, buf, len);
          if (ret<  0) {
+            if (errno == EAGAIN&&  nonblock) {
+                return -EAGAIN;
+            }

You've just re-introduced the bug you've fixed in patch 1/5 ...

cheers,
  Gerd