On Mon, 13 Jul 2015 10:22:17 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Mon, Jul 13, 2015 at 08:16:17AM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 13:46:50 +0800 > > Jason Wang <jasow...@redhat.com> wrote: > > > > > This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. > > > > > > This is because: > > > - vhost support virtio 1.0 now > > > - transport code (e.g virtio-pci) set this feature when modern is > > > enabled, setting this unconditionally will break disable-modern=on. > > > > *scratches head* > > > > Why is transport code now supposed to set VERSION_1? I thought we > > wanted to have the individual devices offer it, once they are converted. > > Because all devices have been converted now. Excepting bugs, but we can > fix these. Must have missed this. Will rework the virtio-1 enabling patch for virtio-ccw (for 2.5).