On (Tue) May 04 2010 [21:54:09], Juan Quintela wrote: > > static void tcp_chr_connect(void *opaque) > > { > > CharDriverState *chr = opaque; > > TCPCharDriver *s = chr->opaque; > > + IOHandler *write_cb; > > + int flags; > > + bool nonblock; > > + > > + flags = fcntl(s->fd, F_GETFL); > > + if (flags == -1) { > > + flags = 0; > > + } > > + nonblock = flags & O_NONBLOCK; > > + > > + write_cb = NULL; > > + chr->nonblock = false; > > + if (nonblock && chr->chr_write_unblocked) { > > + write_cb = chr->chr_write_unblocked; > > + chr->nonblock = true; > > + } > > > > + chr->write_blocked = false; > > s->connected = 1; > > qemu_set_fd_handler2(s->fd, tcp_chr_read_poll, > > write_cb is a write-only variable, no?
Leftover from previous design. I'll clean this up in the next series (already applied to my local branch). Thanks, Amit