On Tue, Jul 21, 2015 at 10:36:39PM +0200, Laszlo Ersek wrote: > On 07/21/15 22:16, Kevin O'Connor wrote: > > Without this ability we'd need to read the entire > > entry into a big linear area of memory and then memmove that around. > > If there is a way to accomplish this without an "offset" field then > > that's fine too. > > What I meant by "I+J=K" is that the qemu-internal offset into the > selected fw_cfg blob is not (and should not) be reset between calls.
I missed that in my earlier review of the code. With that in place, I agree that the offset isn't needed. -Kevin