On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Output unchanged except for white-space.
Indeed, and the diffstat shows it was only one blank line: qga-qmp-marshal.c | 1 + 1 file changed, 1 insertion(+) MUCH friendlier to review :) > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi-commands.py | 157 > ++++++++++++++++++++++++++--------------------- > scripts/qapi.py | 2 +- > 2 files changed, 87 insertions(+), 72 deletions(-) > Here, I can confidently say: Reviewed-by: Eric Blake <ebl...@redhat.com> > +++ b/scripts/qapi.py > @@ -1366,7 +1366,7 @@ def c_type(value, is_param=False): > return c_name(value) + pointer_suffix > > def is_c_ptr(value): > - return c_type(value).endswith(pointer_suffix) > + return value.endswith(pointer_suffix) Perhaps this cleanup could be floated earlier in the series? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
