On 24 July 2015 at 06:10, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 23/07/2015 22:10, Peter Maydell wrote: >>> > The series looks good, but I'd prefer (especially for patch 4 which is >>> > in a fast path) if pow2ceil and pow2floor were made inline. >> Yeah, I was wondering if I was going to be asked to do that. >> Note that qemu_fls() is/was *not* inline, though, so you're >> taking an out-of-line function call on these code paths >> already. > > But in patch 4 the call is only in the rare case where "l & (l - 1)" is > not zero.
True. Any preferences for which header file to put them in? qemu-common.h is where the prototype is currently and where the inline is_power_of_2() is defined... thanks -- PMM
