On 24 July 2015 at 10:55, Pavel Fedin <p.fe...@samsung.com> wrote: > This patch introduces kernel_irqchip_type member in Machine class, which > is passed to kvm_arch_irqchip_create. Machine models which can use vGIC > now use it in order to supply correct GIC type for KVM capability > verification. The variable is defined as int in order to be > architecture-agnostic for potential future uses by other architectures.
This doesn't look right. The board model should just create the GIC device that it wants, and it should be the job of the GIC device itself to coordinate with the kvm.c code if it has to do so to pass the right kind of irqchip type. thanks -- PMM
